Page MenuHomePhabricator

[X86] Fix Stale SDNode use in X86ISelDAGtoDAG
ClosedPublic

Authored by niravd on Mar 23 2017, 7:49 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

niravd created this revision.Mar 23 2017, 7:49 AM
chandlerc accepted this revision.Mar 23 2017, 7:56 AM
chandlerc added a subscriber: chandlerc.

The fix seems trivial and looks good. Please submit to at least fix the crasher.

One note for this and future, similar patches: can you minimize the test case any? At the least stripping off some of the metadata cruft and comment boiler plate would be good.

Also, please always run FileCheck and assert that reasonable instructions are generated. "doesn't crash" isn't the most useful test case, and small cases like this should be easy to check that sane instructions come out.

This revision is now accepted and ready to land.Mar 23 2017, 7:56 AM
This revision was automatically updated to reflect the committed changes.