Page MenuHomePhabricator

[libc++] Add option to disable new/delete overloads when libc++abi provides them.
ClosedPublic

Authored by EricWF on Mar 1 2017, 4:42 PM.

Details

Summary

Currently both libc++ and libc++abi provide definitions for operator new/delete. However I believe this is incorrect and that one or the other should offer them.

This patch adds the CMake option -DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS which defaults no ON unless -DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS=ON is specified.

Diff Detail

Event Timeline

EricWF created this revision.Mar 1 2017, 4:42 PM
chrisbolt resigned from this revision.Mar 1 2017, 6:40 PM
This revision is now accepted and ready to land.Mar 1 2017, 8:51 PM
rmaprath edited edge metadata.Mar 2 2017, 3:50 AM

Thanks for these patches!

We had some downstream hacks to workaround this, never got around to sort it out. Now it looks much better.

EricWF closed this revision.Mar 2 2017, 11:47 AM