This is an archive of the discontinued LLVM Phabricator instance.

Make some diagnostic tests C++11 clean
ClosedPublic

Authored by probinson on Dec 14 2016, 6:22 PM.

Details

Summary

Another half-dozen test revisions in the ongoing campaign to make things ready for C++11 as Clangs's default dialect.

Most of these are straightforward, but I am not entirely sure about a couple of things:

  • In fixit.cpp, the place that now gets 'expected unqualified-id' seems funny, but maybe that's just the nature of things
  • In copy-assignment.cpp, I am bemused by the whole thing but especially 'passing argument to parameter here'

Diff Detail

Repository
rL LLVM

Event Timeline

probinson updated this revision to Diff 81516.Dec 14 2016, 6:22 PM
probinson retitled this revision from to Make some diagnostic tests C++11 clean.
probinson updated this object.
probinson added a reviewer: rsmith.
probinson added subscribers: cfe-commits, tigerleapgorge.

+abataev for OpenMP.

ABataev edited edge metadata.Dec 16 2016, 4:54 AM

LG for OpenMP part

probinson updated this revision to Diff 81977.Dec 19 2016, 11:23 AM
probinson added a reviewer: rnk.

Remove the OpenMP tests from this review (committed in r290128).

+rnk who added test/Parser/backtrack-off-by-one.cpp originally.

rnk accepted this revision.Dec 21 2016, 9:57 AM
rnk edited edge metadata.

Everything here looks good to me.

test/FixIt/fixit.cpp
28 ↗(On Diff #81977)

I guess in C++11 we now parse this as CT<10> > 2 > ct;. I'd add a FIXME comment here to re-enable this recovery in C++11.

This revision is now accepted and ready to land.Dec 21 2016, 9:57 AM
probinson marked an inline comment as done.Dec 21 2016, 10:40 AM

FIXME added.

This revision was automatically updated to reflect the committed changes.