Page MenuHomePhabricator

Introduces cmake option `LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING`
ClosedPublic

Authored by mehdi_amini on Dec 5 2016, 3:49 PM.

Details

Summary

We recently introduced a feature that enforce at link-time that the
LLVM headers used by a clients are matching the ABI setting of the
LLVM library linked to.

However for clients that are using only headers from ADT and promise
they won't call into LLVM, this is forcing to link libSupport. This
new flag is intended to provide a way to configure LLVM with this
promise for such client.

Diff Detail

Repository
rL LLVM

Event Timeline

mehdi_amini updated this revision to Diff 80339.Dec 5 2016, 3:49 PM
mehdi_amini retitled this revision from to Introduces cmake option `LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING`.
mehdi_amini updated this object.
mehdi_amini added reviewers: bob.wilson, compnerd.
mehdi_amini added a subscriber: llvm-commits.
bob.wilson edited edge metadata.Dec 5 2016, 4:47 PM

This looks good to me. I tried it out and it works as expected.

compnerd accepted this revision.Dec 5 2016, 5:25 PM
compnerd edited edge metadata.

Thanks for doing this so quickly.

This revision is now accepted and ready to land.Dec 5 2016, 5:25 PM
This revision was automatically updated to reflect the committed changes.