LLDB help content has accumulated over time without a recent attempt to review it for consistency, accuracy, and clarity. This patch attempts to address all of the above while keeping the text relatively terse.
Details
Diff Detail
Event Timeline
This is great! Thanks for slogging through these. There are a few comments inline.
source/Commands/CommandObjectBreakpoint.cpp | ||
---|---|---|
1318 | Not sure what it means for locations to match a breakpoint. Maybe "all the locations generated by breakpoint 1"? | |
source/Commands/CommandObjectExpression.cpp | ||
225–226 | "the current thread" seems a little terse. It is important that that the expression is run ON the current thread - because you need to know that that thread isn't going to make progress during the expression evaluation, though other threads might. But it is equally important to know that the context for lookups is the current frame. | |
source/Commands/CommandObjectTarget.cpp | ||
4342–4343 | You were pretty consistent about using "modules" not "images". Do you want to do that here? | |
source/Commands/CommandObjectThread.cpp | ||
1107–1108 | I think "when returning" in this context makes it sound like it stops before the function returns. That would be better, but pretty tricky to do. The current command stops AFTER returning from the current function. | |
source/Interpreter/CommandObject.cpp | ||
690–691 | Breakpoint IDs consist major and minor numbers isn't a sentence. Maybe "are specified by" | |
695 | The "just" on this line doesn't add anything, I'd omit it. | |
708 | Why do we support this, when "5.*" and "5" mean exactly the same thing??? |
source/Commands/CommandObjectCommands.cpp | ||
---|---|---|
2272 | 'by by' is one too many 'by's | |
source/Commands/CommandObjectLanguage.cpp | ||
26 | Maybe "Commands specific to a given source language"? We have a notion of language runtime in LLDB, but the 'language' command doesn't really change the state of those, it's just a convenient grouping for commands that are specifically bound to one language |
clang-format applied. Typos and clarity issues previously commented on have been addressed.
Not sure what it means for locations to match a breakpoint. Maybe "all the locations generated by breakpoint 1"?