This is an archive of the discontinued LLVM Phabricator instance.

[include-fixer] Keep dot dot in SymbolInfo file paths.
ClosedPublic

Authored by hokein on Jun 8 2016, 6:44 AM.

Details

Summary

Currently, removing dot dot in header's path doesn't make include-fixer
minimize path correctly in some cases, for example, specify a relative search
path based on the build directory("-I../include/").

Besides, removing dot dot can break symbolic link directories. So don't
removing it for now.

Diff Detail

Event Timeline

hokein updated this revision to Diff 60025.Jun 8 2016, 6:44 AM
hokein retitled this revision from to [include-fixer] Keep dot dot in SymbolInfo file paths..
hokein updated this object.
hokein added reviewers: bkramer, ioeric.
hokein added a subscriber: cfe-commits.
bkramer accepted this revision.Jun 8 2016, 7:54 AM
bkramer edited edge metadata.

Ok, let's try this. Maybe it will solve our path problems once and for all. ONCE AND FOR ALL.

This revision is now accepted and ready to land.Jun 8 2016, 7:54 AM
hokein updated this revision to Diff 60041.Jun 8 2016, 8:10 AM
hokein edited edge metadata.

Rebase.

This revision was automatically updated to reflect the committed changes.