This is an archive of the discontinued LLVM Phabricator instance.

[mips] Require that ABI's are passed in the triple within LLVM.
Needs ReviewPublic

Authored by sdardis on Jun 7 2016, 5:53 AM.

Details

Summary

This patch ties up a loose end so that we can prove that we pass ABI information in the same way as X86. After the buildbots settle, it will be safe to migrate to the method used by ARM/PowerPC.

Patch by: Daniel Sanders

Event Timeline

dsanders updated this revision to Diff 59874.Jun 7 2016, 5:53 AM
dsanders retitled this revision from to [mips] Require that ABI's are passed in the triple within LLVM..
dsanders updated this object.
dsanders added a subscriber: llvm-commits.
dsanders updated this revision to Diff 63786.Jul 13 2016, 2:36 AM

Refreshed patch.

At this point we're down to two (was three) camps of targets and can prove this
due to the addition of the assertion. Once the buildbots are cleared, it's safe
to further migrate to a single camp.

The remaining camps are:

  • Targets that pass ABI information in both the triple and MCTargetOptions (ARM/PowerPC)
  • Targets that pass ABI information in the triple only (Mips/X86/everyone-else).
dsanders updated this object.Jul 13 2016, 2:45 AM
dsanders updated this revision to Diff 64873.Jul 21 2016, 6:42 AM

Refresh and ping

dsanders updated this revision to Diff 65920.Jul 28 2016, 6:21 AM

Refresh and ping

One last ping since I need to either commit this series next week or hand over to a colleague to continue it.

sdardis commandeered this revision.Aug 23 2016, 6:24 AM
sdardis added a reviewer: dsanders.

Taking over this patch series.

sdardis updated this revision to Diff 68981.Aug 23 2016, 6:26 AM
sdardis updated this object.
sdardis edited edge metadata.

Rebase + ping.

sdardis updated this revision to Diff 76726.Nov 2 2016, 9:58 AM

Rebase and ping.

dsanders resigned from this revision.Jul 18 2019, 6:49 PM