This is an archive of the discontinued LLVM Phabricator instance.

Use ProfileSummaryInfo in inline cost analysis
ClosedPublic

Authored by eraman on Jun 6 2016, 4:02 PM.

Details

Summary

Instead of directly using MaxFunctionCount and function entry count to determine callee hotness, use the isHotFunction/isColdFunction methods provided by ProfileSummaryInfo. NFC.

Diff Detail

Repository
rL LLVM

Event Timeline

eraman updated this revision to Diff 59798.Jun 6 2016, 4:02 PM
eraman retitled this revision from to Use ProfileSummaryInfo in inline cost analysis.
eraman updated this object.
eraman added reviewers: vsk, silvas, davidxl.
eraman added a subscriber: llvm-commits.
silvas edited edge metadata.Jun 6 2016, 5:50 PM

Strictly speaking, I don't think this is NFC (e.g. it required changing the tests). But it seems straightforward enough.

davidxl accepted this revision.Jun 7 2016, 10:49 PM
davidxl edited edge metadata.

nice cleanup!

This revision is now accepted and ready to land.Jun 7 2016, 10:49 PM

Strictly speaking, I don't think this is NFC (e.g. it required changing the tests). But it seems straightforward enough.

Sorry, I meant it in the sense of it doesn't change the functionality of inliner.

David, IIRC patches need an explicit LGTM before submitting and accepting the patch in phabricator is not enough.

This revision was automatically updated to reflect the committed changes.