This is an archive of the discontinued LLVM Phabricator instance.

[find-all-symbols] Added hardcode header mapping from header postfix to header name for STL symbols.
ClosedPublic

Authored by ioeric on May 24 2016, 6:13 AM.

Diff Detail

Event Timeline

ioeric updated this revision to Diff 58226.May 24 2016, 6:13 AM
ioeric retitled this revision from to [find-all-symbols] Added hardcode header mapping from header postfix to header name for STL symbols..
ioeric updated this object.
ioeric added reviewers: bkramer, klimek.
ioeric added subscribers: hokein, cfe-commits.
ioeric updated this revision to Diff 58228.May 24 2016, 6:24 AM
  • fixed nits.

This patch is now ready for review.

Sorry that I also refactored FindAllSymbolsAction into a separate file in this patch...should've done that in a separate patch at the very beginning.

bkramer added inline comments.May 24 2016, 7:36 AM
include-fixer/find-all-symbols/tool/STLPostfixHeaderMap.cpp
15

I wonder if it's worth lazy-initializing this map with ManagedStatic or something, having a global with ctor&dtor isn't pretty.

20

random

82

Why is assert.h special?

ioeric updated this revision to Diff 58235.May 24 2016, 7:53 AM
ioeric marked 3 inline comments as done.
  • Fixed postfix header mapping.
bkramer accepted this revision.May 24 2016, 8:03 AM
bkramer edited edge metadata.
This revision is now accepted and ready to land.May 24 2016, 8:03 AM
This revision was automatically updated to reflect the committed changes.