This is an archive of the discontinued LLVM Phabricator instance.

profile] Add support for static counter allocation for value profiling (part-2)
ClosedPublic

Authored by davidxl on May 19 2016, 9:17 PM.

Diff Detail

Event Timeline

davidxl updated this revision to Diff 57889.May 19 2016, 9:17 PM
davidxl retitled this revision from to profile] Add support for static counter allocation for value profiling (part-2).
davidxl updated this object.
davidxl added reviewers: vsk, xur.
davidxl added a subscriber: llvm-commits.
silvas accepted this revision.May 19 2016, 9:55 PM
silvas added a reviewer: silvas.
silvas added a subscriber: silvas.

I have some small cosmetic suggestions but other than that, this looks great!

lib/profile/InstrProfilingValue.c
111

Can you add PROF_WARN in InstrProfilingPort.h to complement PROF_ERR?

Also, a couple wording nitpicks:

  • Can we prefix the message with LLVM Profile: like the other messages to clarify for the user where the message comes from.
  • Can you say "running out of statically-allocated value profiling nodes" to minimize user confusion.
This revision is now accepted and ready to land.May 19 2016, 9:55 PM
davidxl updated this revision to Diff 57895.May 19 2016, 10:27 PM
davidxl edited edge metadata.

Use PROF_WARN maco.

This revision was automatically updated to reflect the committed changes.