Missing parentheses
Inconsistent whitespace
add has_fp64 macro
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
test/Misc/amdgcn.languageOptsOpenCL.cl | ||
---|---|---|
5 ↗ | (On Diff #57692) | #pragma OPENCL EXTENSION cl_xxx : enable |
remove subgroups support.
better tests.
note: I had to add OPENCL_VERSION defines manually, these can be removed once clang correctly reports the version
even better tests
use existing OPENCL_C_VERSION
use -cl-std=CL for explicit OpenCL1.0
lib/Basic/Targets.cpp | ||
---|---|---|
2111 ↗ | (On Diff #57845) | What is the current problem with subgroups? There's no reason we can't support this |
I'll update this patch based on the outcome of D20447
lib/Basic/Targets.cpp | ||
---|---|---|
2111 ↗ | (On Diff #57845) | no problem (other than not implementing any of the required builtins, or exposing cl2.0), since having 1 subgroup per threadgroup is perfectly OK (dunno why this is even an extension). |
report only exported extensions.
int64 atomics, fp16, and 3d image writes are actually not currently exported, but should be more or less done for SI+
test/Misc/r600.languageOptsOpenCL.cl | ||
---|---|---|
4 ↗ | (On Diff #58850) | We should probably add builtin device macros for these |
test/Misc/r600.languageOptsOpenCL.cl | ||
---|---|---|
4 ↗ | (On Diff #58850) | When we ran into similar problem while adding fma. We opted for feature macro(HAS_FMAF) instead of device macro. I suppose I can add HAS_FP64, but it won't have many uses since everyone checks for cl_khr_fp64. |
lib/Basic/Targets.cpp | ||
---|---|---|
2024–2025 ↗ | (On Diff #59080) | I don't think we need this. I want device macros for other tuning and intrinsic availability reasons. Right now there are builtins that only work on some subtargets but no way to test for that |
lib/Basic/Targets.cpp | ||
---|---|---|
2024–2025 ↗ | (On Diff #59080) | Why not have macro per feature that determines intrinsic/optimization availability? [0]http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150420/127643.html |
test/Misc/amdgcn.languageOptsOpenCL.cl | ||
---|---|---|
1 ↗ | (On Diff #59080) | Negative testing? |
tests all extensions against expected outcome (add negative tests)
enable cl_khr_icd (works ok with mesa)