This is an archive of the discontinued LLVM Phabricator instance.

Differential D20182

[clang-tidy] Add missing dependency of libtooling to misc module
ClosedPublic

Authored by etienneb on May 11 2016, 2:24 PM.

Details

Reviewers
alexfh
rnk
Commits
rG4bf0e62d5a04: [clang-tidy] Add missing dependency of libtooling to misc module
rCTE269240: [clang-tidy] Add missing dependency of libtooling to misc module
rL269240: [clang-tidy] Add missing dependency of libtooling to misc module
Summary

The new API for fixit is in libtooling and the library misc in clang-tidy
didn't had the appropriate dependency.

This commit was breaking some build bots:
http://reviews.llvm.org/D19547

This commit tried (but failed) to fix it:
http://reviews.llvm.org/D20180

To repro, you can make a build with these flags:

cmake -DBUILD_SHARED_LIBS=ON

Thanks rnk@ for helping figuring out.

Diff Detail

Repository
rL LLVM

Event Timeline

etienneb updated this revision to Diff 56963.May 11 2016, 2:24 PM
etienneb retitled this revision from to [clang-tidy] Add missing dependency of libtooling to misc module.
etienneb updated this object.
etienneb added reviewers: alexfh, rnk.
etienneb added a subscriber: cfe-commits.
Closed by commit rL269240: [clang-tidy] Add missing dependency of libtooling to misc module (authored by etienneb). · Explain WhyMay 11 2016, 2:38 PM
This revision was automatically updated to reflect the committed changes.
alexfh edited edge metadata.May 11 2016, 3:38 PM

LG. Thanks for fixing.

alexfh mentioned this in D20180: [tooling] Fix missing inline keyworkd, breaking build bot..May 11 2016, 3:39 PM

Revision Contents

PathSize
clang-tools-extra/
trunk/
clang-tidy/
misc/
1 line

Diff 56966

clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Linesadd_clang_library(clangTidyMiscModule
LINK_LIBS LINK_LIBS
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangLex clangLex
clangTidy clangTidy
clangTidyUtils clangTidyUtils
clangTooling
) )