This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Add missing dependency of libtooling to misc module
ClosedPublic

Authored by etienneb on May 11 2016, 2:24 PM.

Details

Summary

The new API for fixit is in libtooling and the library misc in clang-tidy
didn't had the appropriate dependency.

This commit was breaking some build bots:
http://reviews.llvm.org/D19547

This commit tried (but failed) to fix it:
http://reviews.llvm.org/D20180

To repro, you can make a build with these flags:

cmake -DBUILD_SHARED_LIBS=ON

Thanks rnk@ for helping figuring out.

Diff Detail

Event Timeline

etienneb updated this revision to Diff 56963.May 11 2016, 2:24 PM
etienneb retitled this revision from to [clang-tidy] Add missing dependency of libtooling to misc module.
etienneb updated this object.
etienneb added reviewers: alexfh, rnk.
etienneb added a subscriber: cfe-commits.
This revision was automatically updated to reflect the committed changes.
alexfh edited edge metadata.May 11 2016, 3:38 PM

LG. Thanks for fixing.