This is an archive of the discontinued LLVM Phabricator instance.

Use ScopedPrinter in llvm-pdbdump
ClosedPublic

Authored by zturner on May 3 2016, 6:56 PM.

Details

Summary

When printing raw PDB file fields, streams, and records, use the ScopedPrinter class so we have consistency with llvm-readobj's output format.

For the most part this is pretty mechanical, but I had to fix up the test file to conform to the new YAMLesque output format. i added a few additional helper functions to the ScopedPrinter such as one to print a dotted version, etc.

Diff Detail

Event Timeline

zturner updated this revision to Diff 56086.May 3 2016, 6:56 PM
zturner retitled this revision from to Use ScopedPrinter in llvm-pdbdump.
zturner updated this object.
zturner added a reviewer: rnk.
zturner added a subscriber: llvm-commits.
rnk accepted this revision.May 3 2016, 7:52 PM
rnk edited edge metadata.

lgtm This looks awesome. :)

This revision is now accepted and ready to land.May 3 2016, 7:52 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r268506.