This patch is adding support for a matcher to check string literal length.
This matcher is used in clang-tidy checkers and is part of this refactoring:
see: http://reviews.llvm.org/D19841
Differential D19876
Add an AST matcher for string-literal length etienneb on May 3 2016, 10:51 AM. Authored by
Details This patch is adding support for a matcher to check string literal length. This matcher is used in clang-tidy checkers and is part of this refactoring: see: http://reviews.llvm.org/D19841
Diff Detail Event Timeline
Comment Actions Aaron? could you comment on it?
Comment Actions Other opinions?
Comment Actions Aaron? minus re-generation of the doc. note: returned types for both getLength are not the same (APInt vs unsigned int). note: there is a unittest for top-level node that is no longer valid because stringLiteral can be a top-level node now. Comment Actions Yes, this is the direction I was hoping for, thank you!
Perfect!
Thank you for that explanation, I was curious about that. :-) |
Split these onto two lines?