This is an archive of the discontinued LLVM Phabricator instance.

[lit] Add %:[STpst] to represent paths without Windows drive letters.
ClosedPublic

Authored by ruiu on Apr 29 2016, 6:15 PM.

Details

Summary

We need these variables to concatenate two absolute paths to construct
a valid path. Currently, %t/%t is, for example, expanded to C:/foo/C:/foo,
which is not a valid path because ":" is not a valid path character
on Windows.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 55696.Apr 29 2016, 6:15 PM
ruiu retitled this revision from to [lit] Add %:[STpst] to represent paths without Windows drive letters..
ruiu updated this object.
ruiu added a reviewer: rnk.
ruiu added a subscriber: llvm-commits.
rnk edited edge metadata.Apr 29 2016, 6:18 PM

I thought we wanted this behavior:

C:/foo -> C/foo

Is LLD doing something different in the reproducer?

ruiu updated this revision to Diff 55697.Apr 29 2016, 6:37 PM
ruiu edited edge metadata.
  • Update as per Reid's comment.
rafael accepted this revision.Apr 30 2016, 11:00 AM
rafael added a reviewer: rafael.
rafael added a subscriber: rafael.

LGTM

This revision is now accepted and ready to land.Apr 30 2016, 11:00 AM
ruiu added a comment.Apr 30 2016, 2:30 PM

I don't think UNC names (paths start with \\) have colons in them, so we don't need to remove anything from UNC names.

This revision was automatically updated to reflect the committed changes.