[ASan] Reenable __builtin_setjmp test on PowerPC, disable on SystemZ.

[• koriakin]

Summary

Since __builtin_setjmp has been fixed by rL267943, the test now works
on PowerPC. Enable it.

On the other hand, the SystemZ backend doesn't currently support
__builtin_setjmp. Disable it.

[joerg]

That's not true. __builtin_longjmp is (currently) supported on X86, PowerPC and ARM. Support for SPARC is currently being worked on.

[• koriakin]

In D19657#415491, @joerg wrote:

That's not true. __builtin_longjmp is (currently) supported on X86, PowerPC and ARM. Support for SPARC is currently being worked on.

Hm, fair enough. I'll try to figure out what's wrong with this test on PowerPC, then.

[• koriakin]

In D19657#415594, @koriakin wrote:

In D19657#415491, @joerg wrote:

That's not true. __builtin_longjmp is (currently) supported on X86, PowerPC and ARM. Support for SPARC is currently being worked on.

Hm, fair enough. I'll try to figure out what's wrong with this test on PowerPC, then.

Ugh, clang miscompiles __builtin_setjmp on PowerPC when using internal assembler - there's a stray 0 word in the code section, seems it tries to print an invalid MachineInstr somehow. I'll fix that.

However, I'm not sure about ARM - the emitted code looks OK to me, and I don't have the hardware to run the test. Could someone shed some light here?

Btw, what's so useful about __builtin_longjmp/setjmp that someone's implementing it on SPARC? I thought it was just an ancient exception handling artifact...

[• koriakin]

Since the test can actually work on multiple platforms (all of them presumably, given support from backend), let's keep the blacklist. However, disable it for the upcoming SystemZ port, which currently doesn't support the builtin, and reenable it for PowerPC, whose builtin has just been fixed.

[• koriakin]

Turns out this file doesn't include sanitizer_common.h, so we can't use SANITIZER_* defines - fixed to use s390 and friends.

compiler-rt/trunk/lib/asan/tests/asan_test.cc

NOINLINE void SigLongJmpFunc1(sigjmp_buf buf) {
 
   int *A = Ident(&a);
   int *B = Ident(&b);
   *A = *B;
   siglongjmp(buf, 1);
 }
 
 #if !defined(__ANDROID__) && !defined(__arm__) && \
-    !defined(__powerpc64__) && !defined(__powerpc__) && \
     !defined(__aarch64__) && !defined(__mips__) && \
-    !defined(__mips64)
+    !defined(__mips64) && !defined(__s390__)
 NOINLINE void BuiltinLongJmpFunc1(jmp_buf buf) {
   // create three red zones for these two stack objects.
   int a;
   int b;
 
   int *A = Ident(&a);
   int *B = Ident(&b);
   *A = *B;
   __builtin_longjmp((void**)buf, 1);
 }
 
-// Does not work on Power and ARM:
+// Does not work on ARM:
 // https://github.com/google/sanitizers/issues/185
 TEST(AddressSanitizer, BuiltinLongJmpTest) {
   static jmp_buf buf;
   if (!__builtin_setjmp((void**)buf)) {
     BuiltinLongJmpFunc1(buf);
   } else {
     TouchStackFunc();
   }
 }
-#endif  // !defined(__ANDROID__) && !defined(__powerpc64__) &&
-        // !defined(__powerpc__) && !defined(__arm__) &&
-        // !defined(__mips__) && !defined(__mips64)
+#endif  // !defined(__ANDROID__) && !defined(__arm__) &&
+        // !defined(__aarch64__) && !defined(__mips__)
+        // !defined(__mips64) && !defined(__s390__)
 
 TEST(AddressSanitizer, UnderscopeLongJmpTest) {
   static jmp_buf buf;
   if (!_setjmp(buf)) {
     UnderscopeLongJmpFunc1(buf);
   } else {
     TouchStackFunc();
   }