tests/test_suite: Do not hide commandlines

[MatzeB]

Summary

Remove the concept of a verbose mode. It was hiding the interesting information of
how cmake and lit were invoked (while we have no problem spamming the user with the full make and lit outputs).

[cmatthews]

Last time we did this, all the public buildbots died because they were no longer able to parse the output.

I'd rather this is turned on though, and someone fixes the parser if it breaks.

[MatzeB]

In D19616#414514, @cmatthews wrote:

Last time we did this, all the public buildbots died because they were no longer able to parse the output.

I'd rather this is turned on though, and someone fixes the parser if it breaks.

Are you talking about jenkins plugins processing the output on green dragon?

[cmatthews]

The issue I’m referring to was on the public buildbots.

lnt/trunk/lnt/tests/test_suite.py

def run_test(self, name, args):
         group.add_option("", "--submit", dest="submit_url", metavar="URLORPATH",
                          help=("autosubmit the test result to the given server"
                                " (or local instance) [%default]"),
                          type=str, default=None)
         group.add_option("", "--commit", dest="commit",
                          help=("whether the autosubmit result should be committed "
                                "[%default]"),
                          type=int, default=True)
-        group.add_option("-v", "--verbose", dest="verbose",
-                         help="show verbose test results",
-                         action="store_true", default=False)
         group.add_option("", "--succinct-compile-output",
                          help="run Make without VERBOSE=1",
                          action="store_true", dest="succinct")
         group.add_option("", "--exclude-stat-from-submission",
                          dest="exclude_stat_from_submission",
                          help="Do not submit the stat of this type [%default]",
                          action='append', choices=KNOWN_SAMPLE_KEYS,
                          type='choice', default=[])
class TestSuiteTest(BuiltinTest):
 
     def _build_threads(self):
         return self.opts.build_threads or self.opts.threads
 
     def _test_threads(self):
         return self.opts.threads
 
     def _check_call(self, *args, **kwargs):
-        if self.opts.verbose:
-            note('Execute: %s' % ' '.join(args[0]))
-            if 'cwd' in kwargs:
-                note('          (In %s)' % kwargs['cwd'])
         return subprocess.check_call(*args, **kwargs)
     
     def _clean(self, path):
         make_cmd = self.opts.make
 
         subdir = path
         if self.opts.only_test:
             components = [path] + [self.opts.only_test[0]]