This is the follow-up patch for http://reviews.llvm.org/D19436
- Update the discriminator reading algorithm to match the assignment algorithm.
- Add test to cover the new algorithm.
Paths
| Differential D19522
Read discriminators correctly from object file. ClosedPublic Authored by danielcdh on Apr 25 2016, 9:48 PM.
Details Summary This is the follow-up patch for http://reviews.llvm.org/D19436
Diff Detail Event Timelinedanielcdh updated this object. Comment Actions Usually we try to reduce the source code before generating the IR test case (also, sometimes we checkin binaries to test the dumper - we don't always,
Comment Actions Unfortunately, we can't because I need to have two consecutive line 4 discriminator 0 But with my test case, the code sequence will be: line 4 discriminator 0 Comment Actions Fixed another bug in the implemantation to make it consistent with gnu assembler. PTAL, Thanks This revision is now accepted and ready to land.Apr 28 2016, 3:01 PM
Revision Contents
Diff 55367 lib/DebugInfo/DWARF/DWARFDebugLine.cpp
lib/MC/MCDwarf.cpp
test/DebugInfo/X86/discriminator2.ll
test/DebugInfo/X86/discriminator3.ll
|
Would it be simpler/sufficient to do this:
(with column info off? Or, to keep column info on, #define CALLS f1(); f1() and have the body of the function be:
)