This is an archive of the discontinued LLVM Phabricator instance.

Update discriminator assignment algorithm in clang assembler.
ClosedPublic

Authored by danielcdh on Apr 22 2016, 2:31 PM.

Details

Summary

The clang assembler assumes that the discriminator remains the same when there is source line change. The correct behavior is that when there is line change, discriminator will automatically reset to 0.

Diff Detail

Event Timeline

danielcdh updated this revision to Diff 54726.Apr 22 2016, 2:31 PM
danielcdh retitled this revision from to Update discriminator assignment algorithm in clang assembler..
danielcdh updated this object.
danielcdh added reviewers: dnovillo, davidxl.
danielcdh added a subscriber: llvm-commits.
echristo accepted this revision.Apr 22 2016, 2:33 PM
echristo added a reviewer: echristo.
echristo added a subscriber: echristo.

LGTM.

-eric

This revision is now accepted and ready to land.Apr 22 2016, 2:33 PM
danielcdh closed this revision.Apr 22 2016, 2:37 PM