This is an archive of the discontinued LLVM Phabricator instance.

MarkEOLs should only be true for clang-cl.exe.
ClosedPublic

Authored by srhines on Apr 19 2016, 3:15 PM.

Details

Summary

https://llvm.org/bugs/show_bug.cgi?id=27396

This fixes an issue in response files where "\r\n" was being interpreted
as two EOL markers (i.e. we consumed the '\r' as terminating the
previous token, and then parsed the '\n' as a significant EOL). This
breaks response files where joined arguments get split across multiple
lines (like "-x\r\nc"). I also fixed an accidental issue in the
response-file.c test, where the response file is appended to, instead of
being overwritten.

Diff Detail

Event Timeline

srhines updated this revision to Diff 54276.Apr 19 2016, 3:15 PM
srhines retitled this revision from to MarkEOLs should only be true for clang-cl.exe..
srhines updated this object.
srhines added a reviewer: rnk.
srhines added subscribers: llvm-commits, danalbert.
rnk accepted this revision.Apr 19 2016, 3:21 PM
rnk edited edge metadata.

lgtm

test/Driver/response-file.c
7

Nice

This revision is now accepted and ready to land.Apr 19 2016, 3:21 PM
This revision was automatically updated to reflect the committed changes.