Fix include path in ClangTidy.cpp.

[chh]

Summary

https://llvm.org/bugs/show_bug.cgi?id=27355
To compile with other binary output directory structures in build systems like Android.

[alexfh]

clang-tidy/ClangTidy.cpp

61 ↗

(On Diff #54142)

As it is, the change leaves almost no context of where the Checkers.inc file comes from. I'd prefer to leave at least lib/StaticAnalyzer/Checkers/Checkers.inc. Will this work for you?

Another question is how do you deal with other .inc files generated from .td files in llvm/lib/... or llvm/tools/clang/lib/...?

[srhines]

clang-tidy/ClangTidy.cpp

61 ↗

(On Diff #54142)

I think that the other .inc files have proper exported include paths so that you only include the final part of the name.

Looking at llvm/lib/Option/CMakeLists.txt, I see the following export o fthe includes:

ADDITIONAL_HEADER_DIRS
${LLVM_MAIN_INCLUDE_DIR}/llvm/Option
)

Should this export actually be happening in lib/StaticAnalyzer/Checkers/CMakeLists.txt? Even in that case, it will shorten down to just the final name, without any other part of the path (like you are requesting here).

[chh]

This change depends on http://reviews.llvm.org/D19393.

[alexfh]

In D19249#408437, @chh wrote:

This change depends on http://reviews.llvm.org/D19393.

I'm personally fine with the solution in D19393. Removing this from my dashboard until that patch lands.

[alexfh]

Since D19393 is approved, this patch also looks fine.

clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp

 
 namespace {
 static const char *AnalyzerCheckNamePrefix = "clang-analyzer-";
 
 static const StringRef StaticAnalyzerChecks[] = {
 #define GET_CHECKERS
 #define CHECKER(FULLNAME, CLASS, DESCFILE, HELPTEXT, GROUPINDEX, HIDDEN)       \
   FULLNAME,
-#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc"
+#include "clang/StaticAnalyzer/Checkers/Checkers.inc"
 #undef CHECKER
 #undef GET_CHECKERS
 };
 
 class AnalyzerDiagnosticConsumer : public ento::PathDiagnosticConsumer {
 public:
   AnalyzerDiagnosticConsumer(ClangTidyContext &Context) : Context(Context) {}