This is an archive of the discontinued LLVM Phabricator instance.

NFC: make AtomicOrdering an enum class
ClosedPublic

Authored by jfb on Apr 4 2016, 4:14 PM.

Diff Detail

Event Timeline

jfb updated this revision to Diff 52637.Apr 4 2016, 4:14 PM
jfb retitled this revision from to NFC: make AtomicOrdering an enum class.
jfb updated this object.
jfb added reviewers: jyknight, reames.
jfb added a subscriber: cfe-commits.
rsmith accepted this revision.Apr 4 2016, 4:25 PM
rsmith added a reviewer: rsmith.
rsmith added a subscriber: rsmith.

LGTM. Post-commit review is fine for changes like this that mechanically update Clang to match LLVM API changes.

This revision is now accepted and ready to land.Apr 4 2016, 4:25 PM
jyknight accepted this revision.Apr 6 2016, 7:38 AM
jyknight edited edge metadata.

BTW, this change doesn't actually depend on the LLVM change; it could be committed first, as a "normal" enum puts its members both inside the enum name's scope and outside.

This revision was automatically updated to reflect the committed changes.