This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Allow loads with imp-def to be handled in getMemOpBaseRegImmOfsWidth()
ClosedPublic

Authored by junbuml on Mar 31 2016, 12:47 PM.

Details

Summary

This change will allow loads with imp-def to be clustered in machine-scheduler pass.
areMemAccessesTriviallyDisjoint() can also handle loads with imp-def.

Diff Detail

Event Timeline

junbuml updated this revision to Diff 52261.Mar 31 2016, 12:47 PM
junbuml retitled this revision from to [AArch64] Allow loads with imp-def to be handled in getMemOpBaseRegImmOfsWidth().
junbuml updated this object.
junbuml added a subscriber: llvm-commits.

Hi Jun,

I think you should probably be checking MI->getNumExplicitOperands() instead. Other than that it looks like a reasonable change to me.

Tim.

junbuml updated this revision to Diff 52271.Mar 31 2016, 1:17 PM
junbuml edited edge metadata.

Use getNumExplicitOperands() as Tim suggested.
Thanks Tim for the review.

t.p.northover accepted this revision.Mar 31 2016, 1:17 PM
t.p.northover edited edge metadata.

Looks good to me. Thanks for updating!

Tim.

This revision is now accepted and ready to land.Mar 31 2016, 1:17 PM
This revision was automatically updated to reflect the committed changes.