This is an archive of the discontinued LLVM Phabricator instance.

Fix camelCase / non-camelCase typo in dllexport test
ClosedPublic

Authored by wristow on Mar 29 2016, 11:29 PM.

Details

Reviewers
silvas
rnk
Summary

The test case was defining and using a function 'notExported()', but
the FileCheck checks were checking for the name 'not_exported'. This
changes the test to use 'notExported' across the board. Also, the test
defined a function 'not_defined()', but doesn't have any checks related
to it. For consistency, this name is changed to 'notDefined'. A later
commit will add checks for 'notDefined'.

Diff Detail

Event Timeline

wristow updated this revision to Diff 52022.Mar 29 2016, 11:29 PM
wristow retitled this revision from to Fix camelCase / non-camelCase typo in dllexport test.
wristow updated this object.
wristow added reviewers: rnk, silvas.
wristow added a subscriber: llvm-commits.

This is in prep for fixing some -NOT/-SAME issues, under discussion at http://reviews.llvm.org/D17776

silvas accepted this revision.Mar 30 2016, 6:53 PM
silvas edited edge metadata.

r264984, thanks!

This revision is now accepted and ready to land.Mar 30 2016, 6:53 PM
silvas closed this revision.Mar 30 2016, 6:53 PM

Close now that this is landed.