This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Parsing and sema support for the from clause
ClosedPublic

Authored by sfantao on Mar 25 2016, 8:31 PM.

Diff Detail

Event Timeline

kkwli0 updated this revision to Diff 51707.Mar 25 2016, 8:31 PM
kkwli0 retitled this revision from to [OpenMP] Parsing and sema support for the from and to clauses.
kkwli0 updated this object.
ABataev edited edge metadata.Mar 28 2016, 12:43 AM

There must be separate patch for 'from' and separate patch for 'to'

Ok, thanks. I will split it into two patches.

sfantao commandeered this revision.May 24 2016, 6:17 PM
sfantao edited reviewers, added: kkwli0; removed: sfantao.
sfantao retitled this revision from [OpenMP] Parsing and sema support for the from and to clauses to [OpenMP] Parsing and sema support for the from clause.
sfantao updated this object.
sfantao edited reviewers, added: arpith-jacob; removed: fraggamuffin, rsmith.
sfantao added subscribers: cfe-commits, caomhin.
sfantao updated this revision to Diff 58371.May 24 2016, 6:20 PM

Implementation and tests only for the from clause. Similarly to the to clause, the implementation is based on the infrastructure contributed before for the map clause.

Missed a test for printing and serialization/deserialization

test/OpenMP/nesting_of_regions.cpp
1832

Again, this test must be updated only for new directives, not clauses

sfantao updated this revision to Diff 58490.May 25 2016, 1:28 PM
sfantao marked an inline comment as done.
  • Rebase and remove changes from the nesting tests.

Hi Alexey,

Thanks for the review!

Missed a test for printing and serialization/deserialization

Maybe it is test/OpenMP/target_update_ast_print.cpp what you were looking for? Let me know if not.

Thanks again,
Samuel

test/OpenMP/nesting_of_regions.cpp
1832

Ok, I'm not touching this test in this patch anymore.

ABataev accepted this revision.May 25 2016, 8:30 PM
ABataev edited edge metadata.

LG

This revision is now accepted and ready to land.May 25 2016, 8:30 PM
sfantao closed this revision.May 26 2016, 10:55 AM