Personality is copied as part of copyFunctionAttributes, but it is
invalid on a declaration. Remove the personality attribute it the
function body is not cloned.
Also add a verifier run over output modules in the llvm-split tool.
Differential D18486
Remove personality for declarations in CloneModule.
eugenis on Mar 25 2016, 4:56 PM. Authored by
Details
Personality is copied as part of copyFunctionAttributes, but it is Also add a verifier run over output modules in the llvm-split tool.
Diff Detail
Event TimelineComment Actions Instead of doing this, we should probably fix the module splitter to not set the personality attribute on a function declaration. What does the verifier make of this? Comment Actions Done.
Verifier is not happy about this, but it is not being run. I've added a verifier pass to llvm-split, do you think it's a good idea? Comment Actions LGTM
Yes, the modules we get from the splitter should verify. |