This is an archive of the discontinued LLVM Phabricator instance.

Fix a missing comma between two string literals.
ClosedPublic

Authored by etienneb on Mar 24 2016, 11:21 AM.

Download Raw Diff

Details

Reviewers

alexfh
arsenm
rnk

Commits

rGe8ae26fb3493: Fix a missing comma between two string literals.
rC264315: Fix a missing comma between two string literals.
rL264315: Fix a missing comma between two string literals.

Summary

The two literals are currently appended.

I'm not sure what was broken by this. Please double check carefully.

Silly bug found by an on-going checker for clang-tidy.

Diff Detail

Event Timeline

etienneb updated this revision to Diff 51574.Mar 24 2016, 11:21 AM

etienneb retitled this revision from to Fix a missing comma between two string literals..

etienneb updated this object.

etienneb added reviewers: alexfh, rnk.

etienneb added a subscriber: cfe-commits.

lgtm, I'd go ahead and land this. I cc'd Matt Arsenault. He works on AMD GPU stuff.

This revision is now accepted and ready to land.Mar 24 2016, 11:30 AM

etienneb closed this revision.Mar 24 2016, 11:34 AM

Revision Contents

Path

Size

lib/

Basic/

Targets.cpp

2 lines

Diff 51574

lib/Basic/Targets.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 2,000 Lines • ▼ Show 20 Lines	const char * const AMDGPUTargetInfo::GCCRegNames[] = {
"s56", "s57", "s58", "s59", "s60", "s61", "s62", "s63",		"s56", "s57", "s58", "s59", "s60", "s61", "s62", "s63",
"s64", "s65", "s66", "s67", "s68", "s69", "s70", "s71",		"s64", "s65", "s66", "s67", "s68", "s69", "s70", "s71",
"s72", "s73", "s74", "s75", "s76", "s77", "s78", "s79",		"s72", "s73", "s74", "s75", "s76", "s77", "s78", "s79",
"s80", "s81", "s82", "s83", "s84", "s85", "s86", "s87",		"s80", "s81", "s82", "s83", "s84", "s85", "s86", "s87",
"s88", "s89", "s90", "s91", "s92", "s93", "s94", "s95",		"s88", "s89", "s90", "s91", "s92", "s93", "s94", "s95",
"s96", "s97", "s98", "s99", "s100", "s101", "s102", "s103",		"s96", "s97", "s98", "s99", "s100", "s101", "s102", "s103",
"s104", "s105", "s106", "s107", "s108", "s109", "s110", "s111",		"s104", "s105", "s106", "s107", "s108", "s109", "s110", "s111",
"s112", "s113", "s114", "s115", "s116", "s117", "s118", "s119",		"s112", "s113", "s114", "s115", "s116", "s117", "s118", "s119",
"s120", "s121", "s122", "s123", "s124", "s125", "s126", "s127"		"s120", "s121", "s122", "s123", "s124", "s125", "s126", "s127",
"exec", "vcc", "scc", "m0", "flat_scratch", "exec_lo", "exec_hi",		"exec", "vcc", "scc", "m0", "flat_scratch", "exec_lo", "exec_hi",
"vcc_lo", "vcc_hi", "flat_scratch_lo", "flat_scratch_hi"		"vcc_lo", "vcc_hi", "flat_scratch_lo", "flat_scratch_hi"
};		};

ArrayRef<const char *> AMDGPUTargetInfo::getGCCRegNames() const {		ArrayRef<const char *> AMDGPUTargetInfo::getGCCRegNames() const {
return llvm::makeArrayRef(GCCRegNames);		return llvm::makeArrayRef(GCCRegNames);
}		}

▲ Show 20 Lines • Show All 6,113 Lines • Show Last 20 Lines