Typesafe visualization of PointerIntPairs in Visual Studio

[mspertus]

Summary

In the <DisplayString> of PointerIntPair , I cast the pointer to the actual type, so VS can leverage it while visualizing, not unlike the recent change to PointerUnion visualization.
In the expansion, the current code is casting to the incorrect type (wrong number of stars), so I fixed that as well.

Note to Reviewers: I will continue to make frequent changes to the MSVC visualizers. While these are worthwhile, I don't want to overwhelm the reviewers. Is it OK for me to request review after commit in the future when I judge that it is appropriate to do so (E.g., this diff)?

[aaron.ballman]

LGTM!

Note to Reviewers: I will continue to make frequent changes to the MSVC visualizers. While these are worthwhile, I don't want to overwhelm the reviewers. Is it OK for me to request review after commit in the future when I judge that it is appropriate to do so (E.g., this diff)?

I am perfectly happy to do post-commit reviews for changes to natvis files moving forward.

[mspertus]

Committed as revision 263821.

Thanks for the trust, Aaron! Note that my next revision (function and member prototype visualization) will be largish, and I would still appreciate a review before commit.

llvm.natvis

<Expand>
       <ArrayItems>
         <Size>Length</Size>
         <ValuePointer>Data</ValuePointer>
       </ArrayItems>
     </Expand>
   </Type>
 
   <Type Name="llvm::PointerIntPair&lt;*,*,*,*&gt;">
-    <DisplayString>{(void*)(Value &amp; PointerBitMask)} [{($T3)((Value &gt;&gt; IntShift) &amp; IntMask)}]</DisplayString>
+    <DisplayString>{IntMask}: {($T1)(Value &amp; PointerBitMask)} [{($T3)((Value &gt;&gt; IntShift) &amp; IntMask)}]</DisplayString>
     <Expand>
-      <Item Name="[ptr]">($T1*)(Value &amp; PointerBitMask)</Item>
+      <Item Name="[ptr]">($T1)(Value &amp; PointerBitMask)</Item>
       <Item Name="[int]">($T3)((Value &gt;&gt; IntShift) &amp; IntMask)</Item>
     </Expand>
   </Type>
 
   <Type Name="llvm::PointerUnion&lt;*,*&gt;">
     <DisplayString Condition="((Val.Value &gt;&gt; Val.IntShift) &amp; Val.IntMask) == 0">{"$T1", s8b}: {($T1)(Val.Value &amp; Val.PointerBitMask)}</DisplayString>
     <DisplayString Condition="((Val.Value &gt;&gt; Val.IntShift) &amp; Val.IntMask) != 0">{"$T2", s8b}: {($T2)(Val.Value &amp; Val.PointerBitMask)}</DisplayString>
     <Expand>