This is an archive of the discontinued LLVM Phabricator instance.

[test] Correctly retry connections on android targets
ClosedPublic

Authored by labath on Mar 14 2016, 7:51 AM.

Details

Summary

Normally, when the remote stub is not ready, we will get ECONNREFUSED during the connect()
attempt. However, due to the way how ADB forwarding works, on android targets the connect() will
always be successful, but the connection will be immediately dropped if ADB could not connect on
the remote side. This commit tries to detect this situation, and report it as "connection
refused" so that the upper test layers attempt the connection again.

Diff Detail

Event Timeline

labath updated this revision to Diff 50593.Mar 14 2016, 7:51 AM
labath retitled this revision from to [test] Correctly retry connections on android targets.
labath updated this object.
labath added reviewers: tfiala, tberghammer.
labath added a subscriber: lldb-commits.
tberghammer accepted this revision.Mar 14 2016, 8:32 AM
tberghammer edited edge metadata.

Looks good

This revision is now accepted and ready to land.Mar 14 2016, 8:32 AM
labath updated this revision to Diff 50600.Mar 14 2016, 8:37 AM
labath edited edge metadata.

Fix comment

This revision was automatically updated to reflect the committed changes.