Eliminate the TestStarted-XXX and TestFinished-XXX files from the test traces

[amccarth]

Summary

Nobody seems to know what purpose these files serve, yet they were accumulating by the thousands in the test traces directory. I'm proposing we delete them.

Creating these files accounted for about 2.5% of the time to run ninja check-lldb on my machine, which isn't a lot, but it's something.

[zturner]

lgtm, Pavel does Android build infrastructure need these files for some reason?

[zturner]

Here's the commit that added this functionality:

D:\src\llvm\tools\lldb\test>git show a73ad66a
commit a73ad66a4ee96ccc8e6be4a645cd6b9180a72e4b
Author: Johnny Chen <[e-mail]>
Date:   Thu Aug 16 19:15:21 2012 +0000

    Catch timestamps for the beginning and end of the test suite run.


    git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@162040 91177308-0d34-0410-b5e6-96231b3b80d8

All changes to these lines of code since then have been fixing bugs in the filenames that cause tests to fail, but AFAICT nobody is using it.

[tfiala]

I'm fine with nuking them.

Prior to the parallel test runner, they were probably the most reliable way to tell if a test crashed in the middle of a run, and to figure out what it was. (Maybe - I don't know as I never used them for that or any other purpose).

We now have much more reasonable ways to track overall progress, so I don't see a compelling reason to keep them.

[labath]

In D18017#371362, @zturner wrote:

lgtm, Pavel does Android build infrastructure need these files for some reason?

Nope, let's get rid of them.

[tfiala]

Can we close this now?

[amccarth]

This was submitted last month. r263122

packages/Python/lldbsuite/test/dotest.py

def run_suite():
     sys.stderr.write("Command invoked: %s\n" % getMyCommandLine())
 
     if not os.path.isdir(configuration.sdir_name):
         try:
             os.mkdir(configuration.sdir_name)
         except OSError as exception:
             if exception.errno != errno.EEXIST:
                 raise
-    where_to_save_session = os.getcwd()
-    fname = os.path.join(configuration.sdir_name, "TestStarted-%d" % os.getpid())
-    with open(fname, "w") as f:
-        print("Test started at: %s\n" % timestamp_started, file=f)
-        print(configuration.svn_info, file=f)
-        print("Command invoked: %s\n" % getMyCommandLine(), file=f)
 
     #
     # Invoke the default TextTestRunner to run the test suite, possibly iterating
     # over different configurations.
     #
 
     iterArchs = False
     iterCompilers = False
if configuration.sdir_has_content and not configuration.parsable:
         sys.stderr.write("Session logs for test failures/errors/unexpected successes"
                          " can be found in directory '%s'\n" % configuration.sdir_name)
 
     if configuration.useCategories and len(configuration.failuresPerCategory) > 0:
         sys.stderr.write("Failures per category:\n")
         for category in configuration.failuresPerCategory:
             sys.stderr.write("%s - %d\n" % (category, configuration.failuresPerCategory[category]))
 
-    os.chdir(where_to_save_session)
-    fname = os.path.join(configuration.sdir_name, "TestFinished-%d" % os.getpid())
-    with open(fname, "w") as f:
-        print("Test finished at: %s\n" % datetime.datetime.now().strftime("%Y-%m-%d-%H_%M_%S"), file=f)
-
     # Terminate the test suite if ${LLDB_TESTSUITE_FORCE_FINISH} is defined.
     # This should not be necessary now.
     if ("LLDB_TESTSUITE_FORCE_FINISH" in os.environ):
         print("Terminating Test suite...")
         subprocess.Popen(["/bin/sh", "-c", "kill %s; exit 0" % (os.getpid())])
 
     # Exiting.
     exitTestSuite(configuration.failed)
 
 if __name__ == "__main__":
     print(__file__ + " is for use as a module only.  It should not be run as a standalone script.")
     sys.exit(-1)