Kill LLVMAddTargetData

[deadalnix]

Summary

It's red, it's dead.

[mehdi_amini]

LGTM, but please add a note in the "release notes" document.

llvm/trunk/bindings/go/llvm/executionengine_test.go

if err != nil {
     t.Errorf("Error creating JIT: %s", err)
     return
   }
   defer engine.Dispose()
 
   pass := NewPassManager()
   defer pass.Dispose()
 
-  pass.Add(engine.TargetData())
   pass.AddConstantPropagationPass()
   pass.AddInstructionCombiningPass()
   pass.AddPromoteMemoryToRegisterPass()
   pass.AddGVNPass()
   pass.AddCFGSimplificationPass()
   pass.Run(mod)
 
   exec_args := []GenericValue{NewGenericValueFromInt(Int32Type(), 10, false)}
   exec_res := engine.RunFunction(fac, exec_args)
   var fac10 uint64 = 10 * 9 * 8 * 7 * 6 * 5 * 4 * 3 * 2 * 1
   if exec_res.Int(false) != fac10 {
     t.Errorf("Expected %d, got %d", fac10, exec_res.Int(false))
   }
 }

llvm/trunk/bindings/go/llvm/target.go

 // See the constructor llvm::TargetData::TargetData.
 func NewTargetData(rep string) (td TargetData) {
   crep := C.CString(rep)
   defer C.free(unsafe.Pointer(crep))
   td.C = C.LLVMCreateTargetData(crep)
   return
 }
 
-// Adds target data information to a pass manager. This does not take ownership
-// of the target data.
-// See the method llvm::PassManagerBase::add.
-func (pm PassManager) Add(td TargetData) {
-  C.LLVMAddTargetData(td.C, pm.C)
-}
-
 // Converts target data to a target layout string. The string must be disposed
 // with LLVMDisposeMessage.
 // See the constructor llvm::TargetData::TargetData.
 func (td TargetData) String() (s string) {
   cmsg := C.LLVMCopyStringRepOfTargetData(td.C)
   s = C.GoString(cmsg)
   C.LLVMDisposeMessage(cmsg)
   return

llvm/trunk/docs/ReleaseNotes.rst

 
 * .. note about C API functions LLVMParseBitcode,
    LLVMParseBitcodeInContext, LLVMGetBitcodeModuleInContext and
    LLVMGetBitcodeModule having been removed. LLVMGetTargetMachineData has been
    removed (use LLVMGetDataLayout instead).
 
 * The C API function LLVMLinkModules has been removed.
 
+* The C API function LLVMAddTargetData has been removed.
+
 .. NOTE
    For small 1-3 sentence descriptions, just add an entry at the end of
    this list. If your description won't fit comfortably in one bullet
    point (e.g. maybe you would like to give an example of the
    functionality, or simply have a lot to talk about), see the `NOTE` below
    for adding a new subsection.
 
 * ... next change ...

llvm/trunk/include/llvm-c/Target.h

 }
 
 /*===-- Target Data -------------------------------------------------------===*/
 
 /** Creates target data from a target layout string.
     See the constructor llvm::DataLayout::DataLayout. */
 LLVMTargetDataRef LLVMCreateTargetData(const char *StringRep);
 
-/** Adds target data information to a pass manager. This does not take ownership
-    of the target data.
-    See the method llvm::PassManagerBase::add. */
-void LLVMAddTargetData(LLVMTargetDataRef TD, LLVMPassManagerRef PM);
-
 /** Adds target library information to a pass manager. This does not take
     ownership of the target library info.
     See the method llvm::PassManagerBase::add. */
 void LLVMAddTargetLibraryInfo(LLVMTargetLibraryInfoRef TLI,
                               LLVMPassManagerRef PM);
 
 /** Converts target data to a target layout string. The string must be disposed
     with LLVMDisposeMessage.

llvm/trunk/lib/Target/Target.cpp

 void LLVMInitializeTarget(LLVMPassRegistryRef R) {
   initializeTarget(*unwrap(R));
 }
 
 LLVMTargetDataRef LLVMCreateTargetData(const char *StringRep) {
   return wrap(new DataLayout(StringRep));
 }
 
-void LLVMAddTargetData(LLVMTargetDataRef TD, LLVMPassManagerRef PM) {
-}
-
 void LLVMAddTargetLibraryInfo(LLVMTargetLibraryInfoRef TLI,
                               LLVMPassManagerRef PM) {
   unwrap(PM)->add(new TargetLibraryInfoWrapperPass(*unwrap(TLI)));
 }
 
 char *LLVMCopyStringRepOfTargetData(LLVMTargetDataRef TD) {
   std::string StringRep = unwrap(TD)->getStringRepresentation();
   return strdup(StringRep.c_str());

llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp

protected:
   void buildMCJITEngine() {
     ASSERT_EQ(
       0, LLVMCreateMCJITCompilerForModule(&Engine, Module, &Options,
                                           sizeof(Options), &Error));
   }
   
   void buildAndRunPasses() {
     LLVMPassManagerRef pass = LLVMCreatePassManager();
-    LLVMAddTargetData(LLVMGetExecutionEngineTargetData(Engine), pass);
     LLVMAddConstantPropagationPass(pass);
     LLVMAddInstructionCombiningPass(pass);
     LLVMRunPassManager(pass, Module);
     LLVMDisposePassManager(pass);
   }
   
   void buildAndRunOptPasses() {
     LLVMPassManagerBuilderRef passBuilder;
     
     passBuilder = LLVMPassManagerBuilderCreate();
     LLVMPassManagerBuilderSetOptLevel(passBuilder, 2);
     LLVMPassManagerBuilderSetSizeLevel(passBuilder, 0);
     
     LLVMPassManagerRef functionPasses =
       LLVMCreateFunctionPassManagerForModule(Module);
     LLVMPassManagerRef modulePasses =
       LLVMCreatePassManager();
     
-    LLVMAddTargetData(LLVMGetExecutionEngineTargetData(Engine), modulePasses);
-    
     LLVMPassManagerBuilderPopulateFunctionPassManager(passBuilder,
                                                       functionPasses);
     LLVMPassManagerBuilderPopulateModulePassManager(passBuilder, modulePasses);
     
     LLVMPassManagerBuilderDispose(passBuilder);
     
     LLVMInitializeFunctionPassManager(functionPasses);
     for (LLVMValueRef value = LLVMGetFirstFunction(Module);