The keyword "template" isn't necessary when
printing a fully-qualified qualtype name, and, in fact,
results in a syntax error if one tries to use it. So stop
printing it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
lgtm
This code seems like it's intended to avoid operating on dependent types, so it shouldn't need the template keyword. It's hard to have a fully qualified name that's valid at global scope and still somehow mentions template parameters.
unittests/Tooling/QualTypeNamesTest.cpp | ||
---|---|---|
138 ↗ | (On Diff #47854) | What's supposed to be printed for dependent_type_var? |
Comment Actions
Thanks for the quick review. Assuming my response to your comment on line 138 is adequate, would you mind checking it in?
unittests/Tooling/QualTypeNamesTest.cpp | ||
---|---|---|
138 ↗ | (On Diff #47854) | I'm not clever enough to generate one that compiles when it is at the end of the TU. When not at the end of the TU, this prints: FOO<X>::dependent_type, omitting the keyword. I don't think this is worth adding as a test-case. |