- User Since
- Nov 6 2015, 10:28 AM (255 w, 1 d)
Mon, Sep 21
Thu, Sep 10
Wed, Sep 2
I am going to accept this, since no one else seems to be able to review it. But the problem here is that no one really knows what a simplified ifdef chain with the same functionality looks like. I tried a couple of times and failed miserably.
Aug 19 2020
Looks good from the FrameHeaderCache side.
Aug 18 2020
Update for comment.
Now just waiting on a libunwind group reviewer.
Rework to match bsd workaround.
Aug 16 2020
Aug 6 2020
This change has a subtle isse with wattr_get and friends: saved_opts isn't actually used, and the documentation for them says to always pass a nullptr. "The parameter opts is reserved for future use, applications must supply a null pointer."
Aug 4 2020
The darwin-dsymutil.c tests this code path right now on line 33. I found this error by running it under asan; otherwise it was fully latent.
Jul 17 2020
This is a reasonable workaround, as it seems to be checking the position of various arguments, and as things work today, lgcc and the compiler-rt variants appear in exactly the same places.
Jul 14 2020
Jul 13 2020
Jun 15 2020
Jun 12 2020
Thanks for the quick response and easy deal. Looking forward to this relanding--it's a good change for sure.
Jun 11 2020
Jun 9 2020
Unfortunately, after this change there are several variables only used in asserts, which creates build failures when assertions are disabled.
Jun 8 2020
For post-commit review.
Jun 1 2020
May 29 2020
I have added the necessary debug info to the .s file--it is a fairly minimal set. I have also removed the checked in binary.
Address upstream concerns about a checked-in binary for the test case.
May 28 2020
Update for upstream comments.
May 26 2020
This is puzzling to me, as we use this internally at Google all over the place, and it seems to work just fine. So I'm surprised we haven't noticed anything.
May 21 2020
May 19 2020
Ping on this?
May 18 2020
Apr 28 2020
Apr 23 2020
Apr 17 2020
Reverted in a4b88c044980337bb14390be654fe76864aa60ec. Happy to approve an updated change.
This change breaks the lldb build with
Apr 16 2020
Appreciate the quick fix. Thanks.
The comparison on lines 81 and 82 of InputChunks.cpp is always true.
Apr 15 2020
The test in this commit writes to a local file (which it ignores). This makes it so the test can't run on a read-only file system. I have committed bf94c960071d338b7157ac7dee8120df50d5600f to fix.
Apr 13 2020
As written, this test writes to the current directory, which assumes that the current directory is writable, but that is not true in all builds. I have committed 215e6bfcfb5af7713ec348f679c7be4d2f32dc82 to fix.
Apr 7 2020
Nice catch. Probably should wait for an unwind owner to accept though.
Apr 2 2020
Don't know why Phab thinks compnerd's accepting the revision March 1, at 9:54 left it in an unaccepted state. Happy to revert it if necessary, but I don't think so.
Mar 31 2020
Mar 30 2020
The harbormaster failures can't possibly be related. For example, the failure below has nothing whatever to do with this change.
Thanks for the comments, I think this catches them all.
updated for all comments.
Mar 26 2020
Add missing file.
Add documentation and otherwise address upstream comments.
Mar 25 2020
Mar 24 2020
Remove short option. It only existed to be parallel to "-s", but conflicts
with options in gnu addr2line.
The clang-format recommendations would change the new options to not match the format of old ones. Not sure the best thing to do there.