I'd like to revive Peter's Compiler.h patch in r237766 from May of last year, defining an LLVM_FALLTHROUGH macro for use in the lldb codebase. It looks like we've got at least half a dozen instances where case statements are not terminated with 'break;' when they should be. I will mark up the places in lldb where we fall through intentionally with this macro and then add -Wimplicit-fallthrough to our clang compile flags; I'd rather add it to the llvm Compiler.h file so we're not duplicating this over in lldb.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM