This is an archive of the discontinued LLVM Phabricator instance.

[CUDA] Make empty parameter lists in nvptx function decls easier to read.
ClosedPublic

Authored by jlebar on Jan 23 2016, 11:28 AM.

Details

Summary

Before:

.func  (.param .b32 func_retval0) _ZL21__nvvm_reflect_anchorv(

)
{

After:

.func  (.param .b32 func_retval0) _ZL21__nvvm_reflect_anchorv()
{

Diff Detail

Repository
rL LLVM

Event Timeline

jlebar updated this revision to Diff 45798.Jan 23 2016, 11:28 AM
jlebar retitled this revision from to [CUDA] Make empty parameter lists in nvptx function decls easier to read..
jlebar updated this object.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, llvm-commits.
bkramer accepted this revision.Jan 23 2016, 11:32 AM
bkramer added a reviewer: bkramer.
bkramer added a subscriber: bkramer.

One nit, looks good otherwise.

lib/Target/NVPTX/NVPTXAsmPrinter.cpp
1439 ↗(On Diff #45798)

arg_empty()

This revision is now accepted and ready to land.Jan 23 2016, 11:32 AM
jlebar updated this revision to Diff 45799.Jan 23 2016, 11:36 AM
jlebar edited edge metadata.

Address bkramer's review comment.

jlebar marked an inline comment as done.Jan 23 2016, 11:36 AM
This revision was automatically updated to reflect the committed changes.