Page MenuHomePhabricator

[ELF] - Refactoring of Writer<ELFT>::scanRelocs()
ClosedPublic

Authored by grimar on Jan 20 2016, 5:26 AM.

Details

Summary

Code for handling TLS relocations was moved out scanRelocs() to new function handleTlsRelocations().
That is because scanRelocs already too large to put more TLS code into it.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar updated this revision to Diff 45382.Jan 20 2016, 5:26 AM
grimar retitled this revision from to [ELF] - Refactoring of Writer<ELFT>::scanRelocs().
grimar updated this object.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar.
ruiu accepted this revision.Jan 20 2016, 2:53 PM
ruiu edited edge metadata.

LGTM

ELF/Writer.cpp
195 ↗(On Diff #45382)

Instead of parameterizing isRela, you can parameterize RelT and change the function signature to bool(unsigned Type, SymbolBody *, InputSectionBase<ELFT> &, RelT &RI)

196 ↗(On Diff #45382)

Relocations -> Relocation because this function handles one relocation at a time.

This revision is now accepted and ready to land.Jan 20 2016, 2:53 PM
emaste added a subscriber: emaste.Jan 20 2016, 3:33 PM
This revision was automatically updated to reflect the committed changes.
grimar marked 2 inline comments as done.
grimar added inline comments.Jan 21 2016, 1:19 AM
ELF/Writer.cpp
196 ↗(On Diff #45382)

Ok, fixed. Just in case my meaning was "handle different types of TLS relocations" so I put (s).