This is an archive of the discontinued LLVM Phabricator instance.

[CUDA] Bail, rather than crash, on va_arg in device code.
ClosedPublic

Authored by jlebar on Jan 19 2016, 2:21 PM.

Diff Detail

Event Timeline

jlebar updated this revision to Diff 45304.Jan 19 2016, 2:21 PM
jlebar retitled this revision from to [CUDA] Bail, rather than crash, on va_arg in device code..
jlebar updated this object.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, jhen, echristo.
jlebar updated this revision to Diff 45305.Jan 19 2016, 2:23 PM

Rename test file.

tra accepted this revision.Jan 19 2016, 3:54 PM
tra edited edge metadata.

Small nit. LGTM otherwise.

lib/Sema/SemaExpr.cpp
11732

Currently CUDAIsDevice does not imply that .CUDA is set. You may end up taking
this path if -fcuda-is-device is passed to C++ compilation.

For now add .CUDA check. We'll fix CUDA options processing separately.

11732–11739

Unneeded {}.

This revision is now accepted and ready to land.Jan 19 2016, 3:54 PM
This revision was automatically updated to reflect the committed changes.
jlebar marked 2 inline comments as done.

Fixed and submitted.