This is an archive of the discontinued LLVM Phabricator instance.

Debugger tuning via gold plugin
ClosedPublic

Authored by probinson on Jan 11 2016, 3:54 PM.

Download Raw Diff

Details

Reviewers

echristo
• rafael

Commits

rG4391d09d6089: LTO via the gold plugin needs to be told about debugger tuning.
rC258712: LTO via the gold plugin needs to be told about debugger tuning.
rL258712: LTO via the gold plugin needs to be told about debugger tuning.

Summary

LTO via the gold plugin needs to be told about debugger tuning.

Diff Detail

Repository: rL LLVM

Event Timeline

probinson updated this revision to Diff 44575.Jan 11 2016, 3:54 PM

probinson retitled this revision from to Debugger tuning via gold plugin.

probinson updated this object.

probinson added a reviewer: echristo.

probinson added a subscriber: cfe-commits.

Herald added a subscriber: mehdi_amini. · View Herald TranscriptJan 11 2016, 3:54 PM

Ping.

LGTM

This revision is now accepted and ready to land.Jan 25 2016, 10:08 AM

Closed by commit rL258712: LTO via the gold plugin needs to be told about debugger tuning. (authored by probinson). · Explain WhyJan 25 2016, 11:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

cfe/

trunk/

lib/

Driver/

Tools.cpp

11 lines

test/

Driver/

lto.c

9 lines

Diff 45893

cfe/trunk/lib/Driver/Tools.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 1,811 Lines • ▼ Show 20 Lines	if (Arg *A = Args.getLastArg(options::OPT_O_Group)) {
else if (A->getOption().matches(options::OPT_O0))		else if (A->getOption().matches(options::OPT_O0))
OOpt = "0";		OOpt = "0";
if (!OOpt.empty())		if (!OOpt.empty())
CmdArgs.push_back(Args.MakeArgString(Twine("-plugin-opt=O") + OOpt));		CmdArgs.push_back(Args.MakeArgString(Twine("-plugin-opt=O") + OOpt));
}		}

if (IsThinLTO)		if (IsThinLTO)
CmdArgs.push_back("-plugin-opt=thinlto");		CmdArgs.push_back("-plugin-opt=thinlto");

		// If an explicit debugger tuning argument appeared, pass it along.
		if (Arg *A = Args.getLastArg(options::OPT_gTune_Group,
		options::OPT_ggdbN_Group)) {
		if (A->getOption().matches(options::OPT_glldb))
		CmdArgs.push_back("-plugin-opt=-debugger-tune=lldb");
		else if (A->getOption().matches(options::OPT_gsce))
		CmdArgs.push_back("-plugin-opt=-debugger-tune=sce");
		else
		CmdArgs.push_back("-plugin-opt=-debugger-tune=gdb");
		}
}		}

/// This is a helper function for validating the optional refinement step		/// This is a helper function for validating the optional refinement step
/// parameter in reciprocal argument strings. Return false if there is an error		/// parameter in reciprocal argument strings. Return false if there is an error
/// parsing the refinement step. Otherwise, return true and set the Position		/// parsing the refinement step. Otherwise, return true and set the Position
/// of the refinement step in the input string.		/// of the refinement step in the input string.
static bool getRefinementStep(StringRef In, const Driver &D,		static bool getRefinementStep(StringRef In, const Driver &D,
const Arg &A, size_t &Position) {		const Arg &A, size_t &Position) {
▲ Show 20 Lines • Show All 8,931 Lines • Show Last 20 Lines

cfe/trunk/test/Driver/lto.c

	Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
	//			//
	// CHECK-LINK-FULL-ACTION: "-plugin" "{{.*}}/LLVMgold.so"			// CHECK-LINK-FULL-ACTION: "-plugin" "{{.*}}/LLVMgold.so"

	// Check that subsequent -fno-lto takes precedence			// Check that subsequent -fno-lto takes precedence
	// RUN: %clang -target x86_64-unknown-linux -### %s -flto=full -fno-lto 2> %t			// RUN: %clang -target x86_64-unknown-linux -### %s -flto=full -fno-lto 2> %t
	// RUN: FileCheck -check-prefix=CHECK-LINK-NOLTO-ACTION < %t %s			// RUN: FileCheck -check-prefix=CHECK-LINK-NOLTO-ACTION < %t %s
	//			//
	// CHECK-LINK-NOLTO-ACTION-NOT: "-plugin" "{{.*}}/LLVMgold.so"			// CHECK-LINK-NOLTO-ACTION-NOT: "-plugin" "{{.*}}/LLVMgold.so"

				// -flto passes along an explicit debugger tuning argument.
				// RUN: %clang -target x86_64-unknown-linux -### %s -flto -glldb 2> %t
				// RUN: FileCheck -check-prefix=CHECK-TUNING-LLDB < %t %s
				// RUN: %clang -target x86_64-unknown-linux -### %s -flto -g 2> %t
				// RUN: FileCheck -check-prefix=CHECK-NO-TUNING < %t %s
				//
				// CHECK-TUNING-LLDB: "-plugin-opt=-debugger-tune=lldb"
				// CHECK-NO-TUNING-NOT: "-plugin-opt=-debugger-tune