Add dump() member function to ArgList.

[echristo]

Can you make this follow the model of print(raw_ostream) + dump() that uses print(OS) similar to the rest of the standard dumps? Also, llvm::dbgs() not llvm::errs() :)

Thanks!

-eric

[jlebar]

Unfortunately not to both, I think. Arg doesn't have a print() I can call. And Arg::dump() writes to errs(), not dbgs().

[jlebar]

If you think it's worthwhile I can try fixing Arg up to idiom in a separate patch. Not sure how much it matters, though.

[echristo]

We appear to be wonderfully consistent about this. In general, I prefer dbgs for this sort of thing.

dzur:~/sources/llvm> grep -r errs\(\) * | wc -l
1461
dzur:~/sources/llvm> grep -r dbgs\(\) * | wc -l
4449

Seems to say dbgs in a very macro sort of way :)

Can also put a print method on Arg if you'd like as a small separate thing?

I'm not too picky, though if you don't do it I'll probably do it for consistency with everything else.

Thanks!

-eric

[echristo]

Since we've got the follow up patch this is also OK.

-eric

[jlebar]

Seems to say dbgs in a very macro sort of way :)

Can also put a print method on Arg if you'd like as a small separate thing?

Done in D15634.

[echristo]

Committed thusly:

dzur:~/sources/llvm> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
M include/llvm/Option/ArgList.h
M lib/Option/ArgList.cpp
Committed r256009

include/llvm/Option/ArgList.h

const char *MakeArgString(const Twine &Str) const {
     return MakeArgStringRef(Str.toStringRef(Buf));
   }
 
   /// \brief Create an arg string for (\p LHS + \p RHS), reusing the
   /// string at \p Index if possible.
   const char *GetOrMakeJoinedArgString(unsigned Index, StringRef LHS,
                                         StringRef RHS) const;
 
+  void dump() const;
+
   /// @}
 };
 
 class InputArgList final : public ArgList {
 private:
   /// List of argument strings used by the contained Args.
   ///
   /// This is mutable since we treat the ArgList as being the list

lib/Option/ArgList.cpp

const char *ArgList::GetOrMakeJoinedArgString(unsigned Index,
   StringRef Cur = getArgString(Index);
   if (Cur.size() == LHS.size() + RHS.size() &&
       Cur.startswith(LHS) && Cur.endswith(RHS))
     return Cur.data();
 
   return MakeArgString(LHS + RHS);
 }
 
+LLVM_DUMP_METHOD void ArgList::dump() const {
+  for (Arg *A : *this) {
+    llvm::errs() << "* ";
+    A->dump();
+  }
+}
+
 //
 
 void InputArgList::releaseMemory() {
   // An InputArgList always owns its arguments.
   for (Arg *A : *this)
     delete A;
 }