This is an archive of the discontinued LLVM Phabricator instance.

lld: test that -e <symbol> actually resolves to a value
ClosedPublic

Authored by emaste on Dec 11 2015, 8:10 AM.

Details

Reviewers
emaste
ruiu
grimar

Diff Detail

Event Timeline

emaste updated this revision to Diff 42525.Dec 11 2015, 8:10 AM
emaste retitled this revision from to lld: test that -e <symbol> actually resolves to a value.
emaste updated this object.
emaste added reviewers: grimar, ruiu.
grimar edited edge metadata.EditedDec 11 2015, 8:22 AM

Looks good for me except I would name it "SYM" as it looks more consistent with others. Its insignificant.
Lets see what Rui think.

emaste accepted this revision.Dec 11 2015, 9:46 AM
emaste added a reviewer: emaste.
This revision is now accepted and ready to land.Dec 11 2015, 9:46 AM

Committed as r255347 as D15454 was accepted

Committed as r255347 as D15454 was accepted

Can this be closed then ?

emaste closed this revision.Dec 17 2015, 5:34 AM