This is an archive of the discontinued LLVM Phabricator instance.

Clang documentation for UBSan.
ClosedPublic

Authored by samsonov on Dec 3 2015, 4:04 PM.

Details

Summary

Create a separate page describing UBSan tool, move the description of
fine-grained checks there, provide extra information about supported
platforms, symbolization etc. This text is compiled from four parts:

Diff Detail

Repository
rL LLVM

Event Timeline

samsonov updated this revision to Diff 41823.Dec 3 2015, 4:04 PM
samsonov retitled this revision from to Clang documentation for UBSan..
samsonov updated this object.
samsonov added reviewers: kcc, rsmith, silvas.
samsonov added a subscriber: kcc.
danalbert added inline comments.Dec 3 2015, 4:26 PM
docs/UndefinedBehaviorSanitizer.rst
128 ↗(On Diff #41823)

Suspicious here meaning that it also checks undefined overflow? Might want to clarify.

rsmith accepted this revision.Dec 3 2015, 4:46 PM
rsmith edited edge metadata.
rsmith added inline comments.
docs/UndefinedBehaviorSanitizer.rst
128 ↗(On Diff #41823)

You mean "defined" rather than "undefined", right? :)

178 ↗(On Diff #41823)

Typo 'for for'

This revision is now accepted and ready to land.Dec 3 2015, 4:46 PM
silvas accepted this revision.Dec 3 2015, 4:53 PM
silvas edited edge metadata.

Thanks for working on this!

A tiny nit, but otherwise this LGTM.

docs/UndefinedBehaviorSanitizer.rst
33 ↗(On Diff #41823)

We support C as well, right? (not a big deal, just mention that this document will focus on C++ usage but C usage is similar)

danalbert added inline comments.Dec 3 2015, 4:54 PM
docs/UndefinedBehaviorSanitizer.rst
128 ↗(On Diff #41823)

I actually meant unsigned, but yes, same thing :)

This revision was automatically updated to reflect the committed changes.
samsonov marked 5 inline comments as done.

Thanks! Addressed the comments.