This is an archive of the discontinued LLVM Phabricator instance.

Patch to google checks in clang-tidy
ClosedPublic

Authored by hallorant on Nov 30 2015, 1:24 PM.

Details

Reviewers
hokein
alexfh
Group Reviewers
Restricted Project
Summary

All of the links in the .h files point to the google.code hosted style guide. This simple patch updates them to github.

Diff Detail

Repository
rL LLVM

Event Timeline

hallorant updated this revision to Diff 41429.Nov 30 2015, 1:24 PM
hallorant retitled this revision from to Patch to google checks in clang-tidy .
hallorant updated this object.
hallorant added a reviewer: Restricted Project.
hallorant set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Please update you patch to current code. Looks like addresses were fixed in files where they existed, but still need to be added to files without them.

hokein accepted this revision.May 19 2016, 12:39 AM
hokein edited edge metadata.

LGTM. Thanks!

This revision is now accepted and ready to land.May 19 2016, 12:39 AM
alexfh requested changes to this revision.May 19 2016, 2:14 AM
alexfh edited edge metadata.

As Eugene noted, the patch is seriously out of date. The only place where an old URL is still used, is docs/clang-tidy/checks/google-runtime-int.rst. However, we should check if style guide links can be added for other checks.

This revision now requires changes to proceed.May 19 2016, 2:14 AM

Anyways, committed all useful changes from here in r270033. Thank you for the patch!

alexfh accepted this revision.May 19 2016, 2:39 AM
alexfh edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 2:39 AM
alexfh closed this revision.May 19 2016, 2:39 AM