This is an archive of the discontinued LLVM Phabricator instance.

[FuncSpec] Do not run pre-link when doing LTO.
ClosedPublic

Authored by labrinea on Mar 6 2023, 8:50 AM.

Details

Summary

Saves time. Post link will cover most cases anyway.

Diff Detail

Event Timeline

labrinea created this revision.Mar 6 2023, 8:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2023, 8:50 AM
labrinea requested review of this revision.Mar 6 2023, 8:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2023, 8:50 AM

Improves geomean of CTMark by a tiny bit (-0.06 % instruction count).

The idea was originally suggested here https://reviews.llvm.org/D93838#inline-983103 but fell through the cracks as it seems.

ChuanqiXu accepted this revision.Mar 6 2023, 5:53 PM
This revision is now accepted and ready to land.Mar 6 2023, 5:53 PM
This revision was landed with ongoing or failed builds.Mar 14 2023, 11:57 AM
This revision was automatically updated to reflect the committed changes.

@labrinea
Hi Alexandros,

Linaro benchmarking CI flagged this patch. After it clang seems to miscompile 602.gcc_s from SPEC CPU2017 for "-O3 -flto" on aarch64-linux-gnu. Also, it appears that 600.perlbench_s slows down by 9%.

Could you investigate, please? Let me know if you need any assistance in reproducing the problem.