- User Since
- Jun 22 2020, 11:08 PM (31 w, 2 d)
Tue, Jan 26
Mon, Jan 25
Wed, Jan 20
Tue, Jan 19
Remove unintentional change.
Mon, Jan 18
@231084fg may I ask why you remove the reviews for the patch?
@jmorse gentle ping~
Sun, Jan 17
I am a little unclear about this problem. From my point of view, it seems like that there is a Coroutine C elided in a normal function F. Then in the Coroutine Body of C, it would try to switch to itself by symmetric transfer. However, the Coroutine frame of C now is a stack variable. Then the tail call would pass the address of the stack variable whose lifetime has ended, so here is the corruption. Did I understand the situation?
Dec 15 2020
Edit the comment to avoid misleading.
Dec 14 2020
add verifyFormat("return *a", PASLeftStyle); to clarify the change
Dec 13 2020
Re-upload patch with context
Nov 25 2020
@djasper gental ping~
Nov 19 2020
Nov 11 2020
Remove unused IsImplicit argument in buildCoawaitCalls.
Good. The intuition and implementation make sense.
Oct 22 2020
Great! To my understanding, if there are lifetime informations, the behavior of this patch is same with the behavior of previous implementation. Is my understanding right?
Oct 10 2020
Oct 9 2020
Oct 8 2020
Thanks for your patch! It mentions some bugs about allocas we need to handle in the future.
Sep 28 2020
Sep 27 2020
rename wouldOptimize to ReuseFrameSlot.
Sep 25 2020
instead OptLevel in CoroSplit with bool to control whether the compiler would optimize a coroutine.
Sep 24 2020
Remove unnecessary headers and declarations.
Sep 22 2020
Change the type of OptLevel in Coro Split Passes as unsigned instead of PassBuilder::OptimizationLevel.
- Remove the feature that we can pass optimization level to opt tool like -passes='coro-split<On>'
- remove redundant addFieldForAlloca and addField
Sep 21 2020
- Move all the implementation details into addFieldForAllocas function.
- Change the type of ForSpill member of Field from pointer to a SmallVector of Spill.
Sep 20 2020
Sep 17 2020
Gate this optimization under optimization level and put the optimization code into a helper class.
Sep 14 2020
Sep 13 2020
Sep 3 2020
Aug 26 2020
Aug 18 2020
Aug 12 2020
@RKSimon , gentle ping~
Aug 6 2020
Update test case
Aug 5 2020
Create BitCastInst directly instead of using IRBuilder
Due to my mistake, the diff updated before is a draft. It is terribly sorry if it confuses any one...