This is an archive of the discontinued LLVM Phabricator instance.

[LLVM] Fix some Clang-tidy modernize warnings, other minor fixes
ClosedPublic

Authored by Eugene.Zelenko on Nov 3 2015, 5:07 PM.

Details

Summary

Fixed warnings are: modernize-use-override, modernize-use-nullptr and modernize-redundant-void-arg.

I checked this patch on my own build on RHEL 6. Regressions were OK.

Diff Detail

Event Timeline

Eugene.Zelenko retitled this revision from to [LLVM] Fix some Clang-tidy modernize warnings, other minor fixes.
Eugene.Zelenko updated this object.
Eugene.Zelenko added a reviewer: hans.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: llvm-commits.
hans accepted this revision.Nov 4 2015, 1:28 PM
hans edited edge metadata.

lgtm

include/llvm-c/Core.h
817

This is exposing new functionality in the C API, but I suppose it's OK.

lib/Support/TimeValue.cpp
27

should we join this with the previous line while here?

lib/Transforms/Scalar/MergedLoadStoreMotion.cpp
111

might as well, drop the explicit I suppose

This revision is now accepted and ready to land.Nov 4 2015, 1:28 PM
Eugene.Zelenko added inline comments.Nov 4 2015, 2:28 PM
lib/Support/TimeValue.cpp
27

Will fix it in commit.

lib/Transforms/Scalar/MergedLoadStoreMotion.cpp
111

Will fix it in commit.

This revision was automatically updated to reflect the committed changes.