This is an archive of the discontinued LLVM Phabricator instance.

[x86] translating "fp" (floating point) instructions from {fadd,fdiv,fmul,fsub,fsubr,fdivr} to {faddp,fdivp,fmulp,fsubp,fsubrp,fdivrp}
ClosedPublic

Authored by m_zuckerman on Nov 1 2015, 8:50 AM.

Details

Summary

LLVM Missing the following instructions: fadd\fdiv\fmul\fsub\fsubr\fdivr.
GAS and MS supporting this instruction and lowering them in to a faddp\fdivp\fmulp\fsubp\fsubrp\fdivrp instructions.

Diff Detail

Event Timeline

m_zuckerman updated this revision to Diff 38850.Nov 1 2015, 8:50 AM
m_zuckerman retitled this revision from to [x86] translating "fp" (floating point) instructions from {fadd,fdiv,fmul,fsub,fsubr,fdivr} to {faddp,fdivp,fmulp,fsubp,fsubrp,fdivrp}.
m_zuckerman updated this object.
m_zuckerman added a subscriber: craig.topper.
rnk edited edge metadata.Nov 2 2015, 3:14 PM

This seems no worse than what we already do. I'm fine with it.

lib/Target/X86/AsmParser/X86AsmParser.cpp
2221

Please put spaces between the comment and the start of the text.

2227

Please use clang-format here.

m_zuckerman updated this revision to Diff 39036.Nov 3 2015, 1:15 AM
m_zuckerman edited edge metadata.
m_zuckerman marked 2 inline comments as done.
rnk accepted this revision.Nov 11 2015, 10:19 AM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Nov 11 2015, 10:19 AM
This revision was automatically updated to reflect the committed changes.