Fix bug in suggested fix that truncated variable names to 1 character.
Also, rework the suggested fix to try to remove unnecessary whitespace.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM!
clang-tidy/misc/UnusedParametersCheck.cpp | ||
---|---|---|
25 ↗ | (On Diff #37885) | Are we preferring anonymous namespaces over static functions these days? |
clang-tidy/misc/UnusedParametersCheck.cpp | ||
---|---|---|
25 ↗ | (On Diff #37885) | I didn't know there was a preference. |
clang-tidy/misc/UnusedParametersCheck.cpp | ||
---|---|---|
25 ↗ | (On Diff #37885) | There is, and I just went to find it instead of asking you to do it for me. ;-) http://llvm.org/docs/CodingStandards.html#anonymous-namespaces Since this code doesn't involve any class declarations, static is totally fine. |