This is an archive of the discontinued LLVM Phabricator instance.

Fix bug in suggested fix that truncated variable names to 1 character.
ClosedPublic

Authored by sbenza on Oct 20 2015, 8:24 AM.

Diff Detail

Event Timeline

sbenza updated this revision to Diff 37885.Oct 20 2015, 8:24 AM
sbenza retitled this revision from to Fix bug in suggested fix that truncated variable names to 1 character..
sbenza updated this object.
sbenza added reviewers: alexfh, aaron.ballman.
sbenza added a subscriber: cfe-commits.
aaron.ballman accepted this revision.Nov 1 2015, 1:53 PM
aaron.ballman edited edge metadata.

LGTM!

clang-tidy/misc/UnusedParametersCheck.cpp
25

Are we preferring anonymous namespaces over static functions these days?

This revision is now accepted and ready to land.Nov 1 2015, 1:53 PM
sbenza added inline comments.Nov 11 2015, 7:07 AM
clang-tidy/misc/UnusedParametersCheck.cpp
25

I didn't know there was a preference.
I usually do anon namespaces, but these functions were already here as static.

aaron.ballman added inline comments.Nov 11 2015, 7:12 AM
clang-tidy/misc/UnusedParametersCheck.cpp
25

There is, and I just went to find it instead of asking you to do it for me. ;-) http://llvm.org/docs/CodingStandards.html#anonymous-namespaces

Since this code doesn't involve any class declarations, static is totally fine.

This revision was automatically updated to reflect the committed changes.