This is an archive of the discontinued LLVM Phabricator instance.

Differential D13715

Add initial gmake glue for the NetBSD platform
ClosedPublic

Authored by krytarowski on Oct 13 2015, 6:54 PM.

Details

Reviewers
joerg
brucem
Commits
rGac1cb4fadf31: Add initial gmake glue for the NetBSD platform
rLLDB251171: Add initial gmake glue for the NetBSD platform
rL251171: Add initial gmake glue for the NetBSD platform
Summary

These changes aren't everything what is needed for the autotools target, but it's significantly approaching it.

These changes shouldn't effect the build process on other platforms.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski updated this revision to Diff 37313.Oct 13 2015, 6:54 PM
krytarowski retitled this revision from to Add initial gmake glue for the NetBSD platform.
krytarowski updated this object.
krytarowski added a reviewer: joerg.
krytarowski set the repository for this revision to rL LLVM.
krytarowski added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer. · View Herald TranscriptOct 13 2015, 6:54 PM
brucem requested changes to this revision.Oct 20 2015, 6:58 PM
brucem added a reviewer: brucem.
brucem added a subscriber: brucem.
brucem added inline comments.
lib/Makefile
146

This should be ifeq?

source/Host/Makefile
46

This should be ifeq too, no?

This revision now requires changes to proceed.Oct 20 2015, 6:58 PM
krytarowski updated this revision to Diff 37957.Oct 20 2015, 7:12 PM
krytarowski edited edge metadata.

Typos.

brucem added a comment.Oct 21 2015, 6:35 AM

I think this looks good to me if no one disagrees.

brucem accepted this revision.Oct 23 2015, 4:48 PM
brucem edited edge metadata.
This revision is now accepted and ready to land.Oct 23 2015, 4:48 PM
Closed by commit rL251171: Add initial gmake glue for the NetBSD platform (authored by brucem). · Explain WhyOct 23 2015, 6:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
5 lines
source/
Host/
5 lines
netbsd/
14 lines
Plugins/
4 lines
Platform/
8 lines
NetBSD/
14 lines

Diff 37957

lib/Makefile

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 LinesUSEDLIBS = lldbAPI.a \
LLVMMCDisassembler.a \ LLVMMCDisassembler.a \
LLVMProfileData.a \ LLVMProfileData.a \
LLVMObjCARCOpts.a \ LLVMObjCARCOpts.a \
LLVMSupport.a \ LLVMSupport.a \
lldbPluginPlatformMacOSX.a \ lldbPluginPlatformMacOSX.a \
lldbPluginPlatformLinux.a \ lldbPluginPlatformLinux.a \
lldbPluginPlatformWindows.a \ lldbPluginPlatformWindows.a \
lldbPluginPlatformFreeBSD.a \ lldbPluginPlatformFreeBSD.a \
lldbPluginPlatformNetBSD.a \
lldbPluginPlatformPOSIX.a \ lldbPluginPlatformPOSIX.a \
lldbPluginPlatformKalimba.a \ lldbPluginPlatformKalimba.a \
lldbPluginPlatformAndroid.a \ lldbPluginPlatformAndroid.a \
lldbPluginJITLoaderGDB.a \ lldbPluginJITLoaderGDB.a \
lldbPluginScriptInterpreterNone.a \ lldbPluginScriptInterpreterNone.a \
lldbPluginScriptInterpreterPython.a lldbPluginScriptInterpreterPython.a
# Because GCC requires RTTI enabled for lldbCore (see source/Core/Makefile) it is # Because GCC requires RTTI enabled for lldbCore (see source/Core/Makefile) it is
Show All 23 Lines USEDLIBS += lldbPluginProcessLinux.a \
lldbPluginProcessPOSIX.a lldbPluginProcessPOSIX.a
endif endif
ifneq (,$(filter $(HOST_OS), FreeBSD GNU/kFreeBSD)) ifneq (,$(filter $(HOST_OS), FreeBSD GNU/kFreeBSD))
USEDLIBS += lldbPluginProcessPOSIX.a \ USEDLIBS += lldbPluginProcessPOSIX.a \
lldbPluginProcessFreeBSD.a lldbPluginProcessFreeBSD.a
endif endif
ifeq ($(HOST_OS),NetBSD)
brucemUnsubmitted
Not Done
ReplyInline Actions

This should be ifeq?

brucem: This should be `ifeq`?
USEDLIBS += lldbPluginProcessPOSIX.a
endif
include $(LEVEL)/Makefile.common include $(LEVEL)/Makefile.common
ifeq ($(HOST_OS),MingW) ifeq ($(HOST_OS),MingW)
LLVMLibsOptions += -lws2_32 LLVMLibsOptions += -lws2_32
# Include everything from the .a's into the shared library. # Include everything from the .a's into the shared library.
ProjLibsOptions := -Wl,--whole-archive $(ProjLibsOptions) \ ProjLibsOptions := -Wl,--whole-archive $(ProjLibsOptions) \
-Wl,--no-whole-archive -Wl,--no-whole-archive
endif endif
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines

source/Host/Makefile

Show All 37 Lines
$(eval $(call DIR_SOURCES,linux)) $(eval $(call DIR_SOURCES,linux))
endif endif
ifneq (,$(filter $(HOST_OS), FreeBSD GNU/kFreeBSD)) ifneq (,$(filter $(HOST_OS), FreeBSD GNU/kFreeBSD))
$(eval $(call DIR_SOURCES,posix)) $(eval $(call DIR_SOURCES,posix))
$(eval $(call DIR_SOURCES,freebsd)) $(eval $(call DIR_SOURCES,freebsd))
endif endif
ifeq ($(HOST_OS),NetBSD)
brucemUnsubmitted
Not Done
ReplyInline Actions

This should be ifeq too, no?

brucem: This should be `ifeq` too, no?
$(eval $(call DIR_SOURCES,posix))
$(eval $(call DIR_SOURCES,netbsd))
endif
ifeq ($(HOST_OS),MingW) ifeq ($(HOST_OS),MingW)
$(eval $(call DIR_SOURCES,windows)) $(eval $(call DIR_SOURCES,windows))
endif endif
ifeq ($(HOST_OS),Android) ifeq ($(HOST_OS),Android)
$(eval $(call DIR_SOURCES,posix)) $(eval $(call DIR_SOURCES,posix))
$(eval $(call DIR_SOURCES,linux)) $(eval $(call DIR_SOURCES,linux))
$(eval $(call DIR_SOURCES,android)) $(eval $(call DIR_SOURCES,android))
endif endif
LIBRARYNAME := lldbHost LIBRARYNAME := lldbHost
BUILD_ARCHIVE = 1 BUILD_ARCHIVE = 1
include $(LLDB_LEVEL)/Makefile include $(LLDB_LEVEL)/Makefile

source/Host/netbsd/Makefile

  • This file was added.
##===- source/Host/netbsd/Makefile --------------------------*- Makefile -*-===##
#
# The LLVM Compiler Infrastructure
#
# This file is distributed under the University of Illinois Open Source
# License. See LICENSE.TXT for details.
#
##===----------------------------------------------------------------------===##
LLDB_LEVEL := ../../..
LIBRARYNAME := lldbHostNetBSD
BUILD_ARCHIVE = 1
include $(LLDB_LEVEL)/Makefile

source/Plugins/Makefile

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines
ifeq ($(HOST_OS),Linux) ifeq ($(HOST_OS),Linux)
PARALLEL_DIRS += Process/Linux Process/POSIX PARALLEL_DIRS += Process/Linux Process/POSIX
endif endif
ifneq (,$(filter $(HOST_OS), FreeBSD GNU/kFreeBSD)) ifneq (,$(filter $(HOST_OS), FreeBSD GNU/kFreeBSD))
PARALLEL_DIRS += Process/FreeBSD Process/POSIX PARALLEL_DIRS += Process/FreeBSD Process/POSIX
endif endif
ifeq ($(HOST_OS),NetBSD)
PARALLEL_DIRS += Process/POSIX
endif
include $(LLDB_LEVEL)/Makefile include $(LLDB_LEVEL)/Makefile

source/Plugins/Platform/Makefile

##===- source/Plugins/Platform/Makefile --------------------*- Makefile -*-===## ##===- source/Plugins/Platform/Makefile --------------------*- Makefile -*-===##
# #
# The LLVM Compiler Infrastructure # The LLVM Compiler Infrastructure
# #
# This file is distributed under the University of Illinois Open Source # This file is distributed under the University of Illinois Open Source
# License. See LICENSE.TXT for details. # License. See LICENSE.TXT for details.
# #
##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
LLDB_LEVEL := ../../.. LLDB_LEVEL := ../../..
include $(LLDB_LEVEL)/../../Makefile.config include $(LLDB_LEVEL)/../../Makefile.config
PARALLEL_DIRS := gdb-server MacOSX Linux FreeBSD POSIX Windows Kalimba Android PARALLEL_DIRS := gdb-server MacOSX Linux FreeBSD NetBSD POSIX Windows Kalimba Android
# ifeq ($(HOST_OS),Darwin) # ifeq ($(HOST_OS),Darwin)
# DIRS += MacOSX # DIRS += MacOSX
# endif # endif
# #
# ifeq ($(HOST_OS),Linux) # ifeq ($(HOST_OS),Linux)
# DIRS += Linux # DIRS += Linux
# endif # endif
# #
# ifeq ($(HOST_OS),FreeBSD) # ifeq ($(HOST_OS),FreeBSD)
# DIRS += FreeBSD # DIRS += FreeBSD
# endif # endif
# #
# ifeq ($(HOST_OS),GNU/kFreeBSD) # ifeq ($(HOST_OS),GNU/kFreeBSD)
# DIRS += FreeBSD # DIRS += FreeBSD
# endif # endif
#
# ifeq ($(HOST_OS),NetBSD)
# DIRS += NetBSD
# endif
include $(LLDB_LEVEL)/Makefile include $(LLDB_LEVEL)/Makefile

source/Plugins/Platform/NetBSD/Makefile

  • This file was added.
##===- source/Plugins/Platform/NetBSD/Makefile ------------*- Makefile -*-===##
#
# The LLVM Compiler Infrastructure
#
# This file is distributed under the University of Illinois Open Source
# License. See LICENSE.TXT for details.
#
##===----------------------------------------------------------------------===##
LLDB_LEVEL := ../../../..
LIBRARYNAME := lldbPluginPlatformNetBSD
BUILD_ARCHIVE = 1
include $(LLDB_LEVEL)/Makefile